Migrate Utf8Formatter to Span<T>.Fill
#52591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
reviewed
May 11, 2021
| @@ -43,7 +43,8 @@ private static bool TryFormatUInt64D(ulong value, byte precision, Span<byte> des | |||
|
|
|||
| if (leadingZeroCount > 0) | |||
| { | |||
| FormattingHelpers.FillWithAsciiZeros(destination.Slice(0, leadingZeroCount)); | |||
| // Fill with ASCII zeros | |||
| destination.Slice(0, leadingZeroCount).Fill((byte)'0'); | |||
There was a problem hiding this comment.
Note that Utf8Formatter is typically going to use this method for very small sizes. Is Array.Fill faster for these small sizes?
There was a problem hiding this comment.
I run some tests, it seems the for loop may be faster for leadingZeroCount < 8.
|
Failures of the following form:
are #52596 |
ghost
closed this
|
Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #51365.